Implement mean min max for impact forecast and hazard forecast #1187
Conversation
…saving impact matrix
…/CLIMADA-project/climada_python into impactCalc_return_impactForecast
…/CLIMADA-project/climada_python into impactCalc_return_impactForecast
luseverin
requested review from
chahank,
emanuel-schmid and
peanutfun
as code owners
|
Probably you need to merge the forecast branch into this one. There are changes in the impact calc that do not belong here I think. |
climada/engine/impact_forecast.py
Outdated
|
|
||
| @property | ||
| def at_event(self): | ||
| LOGGER.warning("at_event for forecasts is not yet implemented.") |
There was a problem hiding this comment.
But this is not true. At event is defined for the forecast.
| red_frequency = np.array([0]) | ||
| return red_event_id, red_event_name, red_date, red_frequency | ||
|
|
||
| def min(self): |
There was a problem hiding this comment.
Is the goal not to reduce along a specified dimension? I am no sure to see the value of getting the minimum impact accross all exposure points, all lead times, and all ensemble members.
There was a problem hiding this comment.
It should reduce along the event dimension. Then we can compute the statistics over the member and/or lead time with the appropriate use of the select function. Does that makes sense?
There was a problem hiding this comment.
For me this method is exposed to the user, so it should directly give back a useful/meaningful result. So I would make the exposed method directly clear. Either over members, or over lead times (or both if the user for some reason wants it). Or make it private if the user is not supposed to use it.
There was a problem hiding this comment.
Sure, I would just make the complete reduction methods above private then.
3 participants
Changes proposed in this PR:
Missing:
This PR fixes #1160
PR Author Checklist
develop)PR Reviewer Checklist